Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugsnag prevents JVM from shutting down normally #151

Closed
smory opened this issue Nov 14, 2019 · 6 comments · Fixed by #157
Closed

Bugsnag prevents JVM from shutting down normally #151

smory opened this issue Nov 14, 2019 · 6 comments · Fixed by #157
Labels
bug Confirmed bug released This feature/bug fix has been released

Comments

@smory
Copy link

smory commented Nov 14, 2019

Expected behavior

When all non daemon threads of any app finish, the JVM shuts down normally... After implementing Bugsnag JVM still runs. This behavior is not what I expect, especially for AWT/Swing apps.

Steps to reproduce

`public class Test {

public static final void main(String[] args) {
    Bugsnag instance = new Bugsnag("api key");
}

}`
JVM will never shut down...

Version

3.6.1

Additional information

If this cannot be fixed, please update your implementation guide to call System.exit(0) or bugsnag.close() somewhere in the code. Calling System.exit(0) is not common in AWT/Swing apps as user closes window and UI thread finishes normally.

This issue made our app update mechanism broken as JVM was running and old jar couldn't be overwritten with new one. Also it made our app unusable after broken update as we use FileLock to enable single instance of app and and lock was never released as JVM kept running. This has broken around 100 installations of our app before we realized what has happened and stopped update. Unfortunately we didn’t discover this bug during our testing, only after it was released to production.
@mattdyoung
Copy link

Hi @smory

Thanks for the report. Our team are just discussing the best way forward to resolve this issue.

@mattdyoung mattdyoung added the needs discussion Requires internal analysis/discussion label Nov 19, 2019
@pawelpasterz pawelpasterz mentioned this issue Mar 8, 2020
Closed
@bootstraponline
Copy link

Hey, we just encountered this same issue at Robinhood. Is there an update on a fix?

@bootstraponline bootstraponline mentioned this issue Mar 8, 2020
Closed
@abigailbramble
Copy link

Hi @bootstraponline thanks for letting us know! We do not currently have an eta for work on this. We will be sure to update back here when we have an update.

@nullobject
Copy link

I just got bitten by this issue in a Dataflow project, the Bugsnag logback appender was causing the process to hang.

Any updates?

@abigailbramble
Copy link

Hi @nullobject no updates at present. We will be sure to update here when there are.

@bugsnagbot bugsnagbot added the scheduled Work is starting on this feature/bug label Nov 2, 2020
tomlongridge added a commit that referenced this issue Nov 6, 2020
@tomlongridge
fix: jVM hangs when System.exit or bugsnag.close is not called
ed26694 
The fix to prevent a resource leak in #143 removed the task scheduler running as
a daemon thread and so doesn't exit unless the application is explicitly exited
(via System.exit) or the thread is explicitly stopped (via bugsnag.close).

This fix should be the benefits of both #143 and #121 to gracefully shutdown in
both use cases.

fixes #151
tomlongridge added a commit that referenced this issue Nov 6, 2020
@tomlongridge
fix: jvm hangs when System.exit or bugsnag.close is not called
96acc03 
The fix to prevent a resource leak in #143 removed the task scheduler running as
a daemon thread and so doesn't exit unless the application is explicitly exited
(via System.exit) or the thread is explicitly stopped (via bugsnag.close).

This fix should be the benefits of both #143 and #121 to gracefully shutdown in
both use cases.

fixes #151
@tomlongridge tomlongridge mentioned this issue Nov 6, 2020
Merged
tomlongridge added a commit that referenced this issue Nov 7, 2020
@tomlongridge
fix: jvm hangs when System.exit or bugsnag.close is not called
2858df2 
The fix to prevent a resource leak in #143 removed the task scheduler running as
a daemon thread and so doesn't exit unless the application is explicitly exited
(via System.exit) or the thread is explicitly stopped (via bugsnag.close).

This fix should be the benefits of both #143 and #121 to gracefully shutdown in
both use cases.

fixes #151
tomlongridge added a commit that referenced this issue Nov 9, 2020
@tomlongridge
fix: jvm hangs when System.exit or bugsnag.close is not called
8e60dd1 
The fix to prevent a resource leak in #143 removed the task scheduler running as
a daemon thread and so doesn't exit unless the application is explicitly exited
(via System.exit) or the thread is explicitly stopped (via bugsnag.close).

This fix should be the benefits of both #143 and #121 to gracefully shutdown in
both use cases.

fixes #151
tomlongridge added a commit that referenced this issue Nov 9, 2020
@tomlongridge
fix: jvm hangs when System.exit or bugsnag.close is not called
01c6ea6 
The fix to prevent a resource leak in #143 removed the task scheduler running as
a daemon thread and so doesn't exit unless the application is explicitly exited
(via System.exit) or the thread is explicitly stopped (via bugsnag.close).

This fix should be the benefits of both #143 and #121 to gracefully shutdown in
both use cases.

Updated the Spring Boot app test and example to remove explict System.exit call
as this should not be required.

fixes #151
tomlongridge added a commit that referenced this issue Nov 9, 2020
@tomlongridge
fix: jvm hangs when System.exit or bugsnag.close is not called
47e71fa 
The fix to prevent a resource leak in #143 removed the task scheduler running as
a daemon thread and so doesn't exit unless the application is explicitly exited
(via System.exit) or the thread is explicitly stopped (via bugsnag.close).

This fix should be the benefits of both #143 and #121 to gracefully shutdown in
both use cases.

Updated the Spring Boot app test and example to remove explict System.exit call
as this should not be required.

fixes #151
@johnkiely1
Copy link
Member

This has now been fixed and released in v3.6.2

@mattdyoung mattdyoung added bug Confirmed bug released This feature/bug fix has been released and removed needs discussion Requires internal analysis/discussion scheduled Work is starting on this feature/bug labels Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bug released This feature/bug fix has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jvm hangs when System.exit or bugsnag.close is not called bugsnag/bugsnag-java
7 participants
@nullobject @bootstraponline @smory @bugsnagbot @mattdyoung @abigailbramble @johnkiely1