Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pipeline #1598

Merged
merged 4 commits into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .buildkite/pipeline.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ steps:
# BrowserStack
#
- label: ':browserstack: iOS 11 E2E tests batch 1'
skip: "https://smartbear.atlassian.net/browse/PLAT-11154"
depends_on:
- cocoa_fixture
# More time than other steps as the BrowserStack iOS 11 devices seem particularly unstable and
Expand Down Expand Up @@ -279,6 +280,7 @@ steps:
limit: 2

- label: ':browserstack: iOS 11 E2E tests batch 2'
skip: "https://smartbear.atlassian.net/browse/PLAT-11154"
depends_on:
- cocoa_fixture
# More time than other steps as the BrowserStack iOS 11 devices seem particularly unstable and
Expand Down
1 change: 1 addition & 0 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ steps:
# BrowserStack
#
- label: ':browserstack: iOS 11 barebone tests'
skip: "https://smartbear.atlassian.net/browse/PLAT-11154"
depends_on:
- cocoa_fixture
timeout_in_minutes: 60
Expand Down
3 changes: 3 additions & 0 deletions features/app_hangs.feature
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ Feature: App hangs
When I run "AppHangDisabledScenario"
Then I should receive no errors

@skip_ios_16 # https://smartbear.atlassian.net/browse/PLAT-11155
Scenario: Fatal app hangs should be reported if appHangThresholdMillis = BugsnagAppHangThresholdFatalOnly
When I run "AppHangFatalOnlyScenario"
And I wait for 6 seconds
Expand Down Expand Up @@ -137,6 +138,7 @@ Feature: App hangs
And the event "session.events.handled" equals 0
And the event "session.events.unhandled" equals 1

@skip_ios_16 # https://smartbear.atlassian.net/browse/PLAT-11155
Scenario: Fatal app hangs should not be reported if enabledErrorTypes.appHangs = false
When I run "AppHangFatalDisabledScenario"
And I wait for 5 seconds
Expand All @@ -145,6 +147,7 @@ Feature: App hangs
Then I should receive no errors

@skip_macos
@skip_ios_16 # https://smartbear.atlassian.net/browse/PLAT-11155
Scenario: Fatal app hangs should be reported if the app hangs before going to the background
When I run "AppHangFatalOnlyScenario"
And I wait for 5 seconds
Expand Down
6 changes: 3 additions & 3 deletions features/fixtures/ios/iOSTestApp/CommandReaderThread.swift
Original file line number Diff line number Diff line change
Expand Up @@ -81,19 +81,19 @@ class CommandReaderThread: Thread {
}

private func logInfo(_ message: String) {
let fullMessage = String(format: "bugsnagci info: %s", message)
let fullMessage = String(format: "bugsnagci info: %@", message)
NSLog("%@", fullMessage)
kslog("\(Date()) \(fullMessage)")
}

private func logWarn(_ message: String) {
let fullMessage = String(format: "bugsnagci warn: %s", message)
let fullMessage = String(format: "bugsnagci warn: %@", message)
NSLog("%@", fullMessage)
kslog("\(Date()) \(fullMessage)")
}

private func logError(_ message: String) {
let fullMessage = String(format: "bugsnagci error: %s", message)
let fullMessage = String(format: "bugsnagci error: %@", message)
NSLog("%@", fullMessage)
kslog("\(Date()) \(fullMessage)")
}
Loading