Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pipeline #1598

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix CI pipeline #1598

merged 4 commits into from
Nov 1, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

Temporarily work around BB issues to get CI pipeline running again.

Copy link

github-actions bot commented Nov 1, 2023

Bugsnag.framework binary size did not change - 713,104 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes so far look fine, but:

  1. I think there are more app hang scenarios that need skipping. "Fatal app hangs should be reported if the app hangs before going to the background" seemed to kill the appium session. I would probably just skip the whole of that feature file.
  2. There are also iOS 11 steps in pipeline.full.yml that need skipping - otherwise the overnight run will just keep failing.

@twometresteve
Copy link
Contributor

Could you also include the trivial changes from https://github.com/bugsnag/bugsnag-cocoa/pull/1595/files to save another loop around the build houses?

@kstenerud kstenerud merged commit c1a80ab into next Nov 1, 2023
37 checks passed
@kstenerud kstenerud deleted the karl-fix-pipeline branch November 1, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants