Don't send null values #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working and just working of a context object. We also don't need to reference the context object permanently.
* Added android support annotations library. * Sprinkled @nonnull and @nullable across various classes where useful to leverage the inspection telling us where a value could be null. * Refactored helper methods to be more self-contained, meaning static and only context dependent. * Overwrote all values methods from JsonWriter in JsonStream, to have the @nonnull annotation but also fallback to nullValue() if necessary.
…and fixed a few typos.
Conflicts: .travis.yml src/main/java/com/bugsnag/android/DeviceState.java
|
Doesn't look like a code issue: |
| * error.setSeverity(Severity.INFO); | ||
| * return true; | ||
| * } | ||
| * }) |
There was a problem hiding this comment.
This formatting probably needs corrected to the original version. Maybe Android Studio would like a <code> block better.
There was a problem hiding this comment.
Multi-line code snippets in Javadoc should use:
<pre>{@code
blah blah
}</pre>
There was a problem hiding this comment.
Ah, that's what I was looking for. Thanks, @JakeWharton. 👍
|
The changes look good. I got a bit bogged down with the unrelated changes, but looked over everything. :) Next up is doing more integrated testing, just for sanity checks. Thanks for putting work into this, @d4rken. |
kattrali
added a commit
that referenced
this pull request
Jan 11, 2016
This was referenced Jan 18, 2016
kattrali
added a commit
to bugsnag/bugsnag-unity
that referenced
this pull request
Apr 15, 2016
Android Changelog ==== ## 3.4.0 (2016-03-09) ### Enhancements - Limit the number of stored errors [Duncan Hewett](https://github.com/duncanhewett) [#97](bugsnag/bugsnag-android#97) ### Bug Fixes - Fix `ConcurrentModificationException` which could occur when saving breadcrumbs [Duncan Hewett](https://github.com/duncanhewett) [#98](bugsnag/bugsnag-android#98) - Localize all numbers in error metrics [Delisa Mason](https://github.com/kattrali) [#100](bugsnag/bugsnag-android#100) 3.3.0 (2016-01-18) ----- ### Enhancements - Change distribution method to be .aar only [Lars Grefer](https://github.com/larsgrefer) [#91](bugsnag/bugsnag-android#91) - Skip sending empty device data values [Matthias Urhahn](https://github.com/d4rken) [#96](bugsnag/bugsnag-android#96) - Remove the need for synthetic methods [Jake Wharton](https://github.com/JakeWharton) [#87](bugsnag/bugsnag-android#87) 3.2.7 (2015-12-10) ----- ### Enhancements - Add additional check to ensure the cache of uploaded errors are deleted [#80](bugsnag/bugsnag-android#80) ### Bug Fixes - Fix exception which occurs when `appContext.getResources()` is null [#78](bugsnag/bugsnag-android#78) - Fix bug preventing `maxBreadcrumbs` from being set [David Wu](https://github.com/wuman) [#70](bugsnag/bugsnag-android#70) 3.2.6 ----- - Add blocking API - Fix NPE issue - Concurrent adding to tabs - Thread Safe DateUtils#toISO8601
lemnik
pushed a commit
that referenced
this pull request
Jun 2, 2021
Add scenario for density apk splits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall goal: Don't write null values into the output stream. See #86
To help with that most methods that produce output for the stream have been made static and self contained. The helper methods and parameters (where applicable) have been annotated to indicate whether the value can be null using Androids annotation library.
Fields holding generated data have also been made final (was suggested by LINT checks).
Android Studio also seems to have corrected some javadoc formatting which was not intended, but oh well...
This also includes the same fixes as PR #92