Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new Xcode 10 build system when using app extensions #97

Closed
blotzy opened this issue Sep 28, 2018 · 3 comments
Closed

Support for new Xcode 10 build system when using app extensions #97

blotzy opened this issue Sep 28, 2018 · 3 comments

Comments

@blotzy
Copy link

blotzy commented Sep 28, 2018

Description

The new Xcode 10 build system fails builds because of circular dependencies when a project contains extensions

Issue

We have a rich push notification extension added via UnityEditor.iOS.Xcode.Extensions.PBXProjectExtensions.AddAppExtension. Removing the extension, removing the BugsnagPostProcess logic that adds the "bugsnag dsym upload script", or reverting to the legacy build system resolves the issue

error: Cycle in dependencies between targets 'Unity-iPhone' and 'NotificationService'; building could produce unreliable results.
Cycle path: Unity-iPhone → NotificationService → Unity-iPhone
{redacted}
○ Target 'NotificationService': Strip /Users/me/Library/Developer/Xcode/DerivedData/Unity-iPhone-bczknawwvgfuzselychrkmftqfug/Build/Intermediates.noindex/ArchiveIntermediates/Unity-iPhone/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/NotificationService.appex/NotificationService
○ That command depends on command in Target 'Unity-iPhone': script phase “Run Script”

Environment

  • bugsnag-unity version: 3.6.5
  • Unity version: 2018.2.8f1
  • Operating system name and version: macOS 10.13.6, Xcode 10.0 (10A255)
  • Target platform names and versions: iOS 12.0
@Cawllec
Copy link
Contributor

Cawllec commented Oct 1, 2018

Hi @blotzy, we're currently in the process of releasing a new version of this notifier. I'll make sure to raise this issue during testing, and we'll add a fix if necessary.

@martin308
Copy link
Contributor

@blotzy good news, I've reproduced this issue and come with a fix for it in #99 which will be included in v4 of the notifier

@avram
Copy link
Contributor

avram commented May 30, 2019

So this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants