Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential segfaults when adding breadcrumb with NDK #546

Merged
merged 8 commits into from
Aug 1, 2019
Merged

Fix potential segfaults when adding breadcrumb with NDK #546

merged 8 commits into from
Aug 1, 2019

Commits on Jul 31, 2019

  1. fix: make Breadcrumb metadata Map immutable

    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    8cf7d98 View commit details
    Browse the repository at this point in the history

  2. fix: add null check for breadcrumb metadata

    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    edc23f9 View commit details
    Browse the repository at this point in the history

  3. fix: add null check for map key when copying breadcrumb to NDK

    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    15b4ab3 View commit details
    Browse the repository at this point in the history

  4. fix: alter ndk metadata sizeof calculation to account for different s… 

    …ize of bsg_char_metadata_pair
    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c0a1d22 View commit details
    Browse the repository at this point in the history

  5. docs: add changelog entry

    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0c2f7c5 View commit details
    Browse the repository at this point in the history

  6. style: use snake case for ndk

    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    91fec68 View commit details
    Browse the repository at this point in the history

  7. allow mutating breadcrumb if accessing map directly

    @fractalwrench
    fractalwrench committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    39d4af7 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-Authored-By: Delisa <kattrali@users.noreply.github.com>
    @fractalwrench @kattrali
    fractalwrench and kattrali committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d221132 View commit details
    Browse the repository at this point in the history