Fix potential segfaults when adding breadcrumb with NDK #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize of bsg_char_metadata_pair
kattrali
reviewed
Jul 31, 2019
bugsnag-android-core/src/main/java/com/bugsnag/android/Breadcrumb.java
Outdated
Show resolved
Hide resolved
kattrali
reviewed
Jul 31, 2019
kattrali
approved these changes
Jul 31, 2019
Co-Authored-By: Delisa <kattrali@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We have noticed infrequent crashes when adding a breadcrumb and NDK error detection is enabled. This changeset fixes some potential causes of this behaviour.
Changeset
Breadcrumbimmutable by taking a defensive copy of the map parameter, and returning a decoratedCollectionfrom the getter that is unmodifiable.sizeofcalculation when iterating through breadcrumb metadataTests
Breadcrumbmetadata immutability