Add a version check for bugsnag-android dependency

CHANGELOG.md

@@ -1,3 +1,11 @@
+
+## 3.2.8 (2018-06-21)
+
+### Bug fixes
+
+* Add a version check for bugsnag-android dependency, disabling redundant ProGuard config if >= v4.6.0
+[Jamie Lynch](https://github.com/fractalwrench) [#116](https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/116)
+
 ## 3.2.8 (2018-06-21)
 
 ### Bug fixes

src/main/groovy/com/bugsnag/android/gradle/BugsnagPlugin.groovy

@@ -10,6 +10,10 @@ import com.android.build.gradle.internal.dsl.BuildType
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.api.Task
+import org.gradle.api.artifacts.Configuration
+import org.gradle.api.artifacts.Dependency
+import org.gradle.util.VersionNumber
+
 /**
  * Gradle plugin to automatically upload ProGuard mapping files to Bugsnag.
  *
@@ -30,11 +34,15 @@ class BugsnagPlugin implements Plugin<Project> {
     static final String BUILD_UUID_TAG = 'com.bugsnag.android.BUILD_UUID'
     static final String GROUP_NAME = 'Bugsnag'
 
+    VersionNumber bugsnagVersionNumber
+
     void apply(Project project) {
         project.extensions.create("bugsnag", BugsnagPluginExtension)
         project.bugsnag.extensions.create("sourceControl", SourceControl)
 
         project.afterEvaluate {
+            bugsnagVersionNumber = getBugsnagAndroidVersionNumber(project)
+            project.logger.debug("Using bugsnag-android version number: $bugsnagVersionNumber")
 
             // Make sure the android plugin has been applied first
             if (project.plugins.hasPlugin(AppPlugin)) {
@@ -55,6 +63,26 @@ class BugsnagPlugin implements Plugin<Project> {
         }
     }
 
+    /**
+     * Retrieves the VersionNumber used by com.bugsnag.android in the given project. This can be used
+     * to conditionally perform tasks depending on the artefact version.
+     */
+    static VersionNumber getBugsnagAndroidVersionNumber(Project project) {
+        List<Configuration> configs = project.configurations.collect()
+        List<Dependency> deps = configs.stream()
+            .map { conf -> conf.allDependencies }
+            .collect()
+            .flatten()
+
+        def bugsnagVersion = deps.stream()
+            .filter { dep -> return dep.group == "com.bugsnag" && dep.name == "bugsnag-android" }
+            .distinct()
+            .map({ dep -> return dep.version })
+            .findFirst()
+
+        return bugsnagVersion.present ? VersionNumber.parse(bugsnagVersion.get()) : VersionNumber.UNKNOWN
+    }
+
     private static void setupNdkProject(Project project) {
         def cleanTasks = project.tasks.findAll {
             it.name.startsWith("externalNative") && it.name.contains("Clean")
@@ -76,7 +104,7 @@ class BugsnagPlugin implements Plugin<Project> {
      * Create tasks for each Build Variant
      * See https://sites.google.com/a/android.com/tools/tech-docs/new-build-system/user-guide#TOC-Build-Variants
      */
-    private static void applyBugsnagToVariant(BaseVariant variant, Project project) {
+    private void applyBugsnagToVariant(BaseVariant variant, Project project) {
         if (hasDisabledBugsnag(variant)) {
             return
         }
@@ -213,14 +241,19 @@ class BugsnagPlugin implements Plugin<Project> {
      * task is named `transformClassesAndResourcesWithProguardForRelease`
      * as it is now part of the "transforms" process.
      */
-    private static void setupProguardAutoConfig(Project project, BaseVariant variant) {
+    private void setupProguardAutoConfig(Project project, BaseVariant variant) {
         BugsnagProguardConfigTask proguardConfigTask = project.tasks.create("processBugsnag${taskNameForVariant(variant)}Proguard", BugsnagProguardConfigTask)
         proguardConfigTask.group = GROUP_NAME
         proguardConfigTask.variant = variant
 
-        if (project.bugsnag.autoProguardConfig) {
+        // consumer proguard rules were added to the library in 4.6.0
+        boolean hasConsumerRules = bugsnagVersionNumber.major >= 4 && bugsnagVersionNumber.minor >= 6
+
+        if (project.bugsnag.autoProguardConfig && !hasConsumerRules) {
             project.logger.debug("Bugsnag autoproguard config enabled")
             dependTaskOnPackageTask(variant, proguardConfigTask)
+        } else {
+            project.logger.debug("ProGuard has consumer rules, skipping write")
         }
     }