Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version check for bugsnag-android dependency #116

Merged
merged 5 commits into from
Jul 6, 2018

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jul 6, 2018

Goal

Adds a version check for the bugsnag-android dependency, and disables writing to proguard files if the version is high enough that consumer proguard rules were already added to that artefact.

Changeset

Adds a method which collects all the dependencies for all the project's configurations, and filters these to find the version number of bugsnag-android. Disables automatic running of the Proguard config task if the version is greater than 4.6.0.

Tests

Manual test by changing the artefact version number in a sample project.

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

Adds a version check for the bugsnag-android dependency, and disables writing to proguard files if
the version is high enough that consumer proguard rules were added
CHANGELOG.md Outdated
@@ -1,3 +1,11 @@

## 3.2.8 (2018-06-21)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be TBD?

kattrali
kattrali previously approved these changes Jul 6, 2018
@fractalwrench fractalwrench changed the base branch from master to next July 6, 2018 14:32
@fractalwrench fractalwrench merged commit 154bfc9 into next Jul 6, 2018
@fractalwrench fractalwrench deleted the add-version-check branch July 6, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants