Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more complete test ignores #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpencerC
Copy link

@SpencerC SpencerC commented Jul 5, 2024

Per #64, adds a slightly more complete example of how these rules might be used in the wild, including violations that require allow_comment_ignores: true to properly ignore.

I suggest adding code like this to the example and adding some language on https://buf.build/docs/build-systems/bazel along the lines of:

Important: allow_comment_ignores: true requires the bazel flag --experimental_proto_descriptor_sets_include_source_info in order to work. (for example bazel test //:root_proto_lint --experimental_proto_descriptor_sets_include_source_info)

Happy to do a PR for the doc update as well if someone can point me in the direction of that repo, if it exists (I couldn't find it easily myself).

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants