Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more complete test ignores #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/bzlmod/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ local_path_override(
buf = use_extension("@rules_buf//buf:extensions.bzl", "buf")

# Override the default version of buf
buf.toolchains(version = "v1.26.0")
buf.toolchains(version = "v1.31.0")

# See https://buf.build/docs/build-systems/bazel#buf-dependencies
buf.dependency(module = "buf.build/envoyproxy/protoc-gen-validate:eac44469a7af47e7839a7f1f3d7ac004")
Expand Down
4 changes: 4 additions & 0 deletions examples/bzlmod/buf.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
version: v1
lint:
use:
- DEFAULT
allow_comment_ignores: true
except:
- IMPORT_USED
- RPC_REQUEST_STANDARD_NAME
13 changes: 13 additions & 0 deletions examples/bzlmod/file.proto
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,16 @@ syntax = "proto3";

import "unused.proto";
import "validate/validate.proto";

message HttpBody {
string name = 1;
}

message Empty {}

service HttpService {
// Receives an inbound message an http client.
// buf:lint:ignore RPC_RESPONSE_STANDARD_NAME
// buf:lint:ignore RPC_REQUEST_RESPONSE_UNIQUE
rpc ReceiveMessage (HttpBody) returns (Empty) {}
}