Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment ignores to example #314

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

SpencerC
Copy link
Contributor

@SpencerC SpencerC commented Jul 5, 2024

buf's allow_comment_ignores functionality does not work out of the box. It requires the bazel --experimental_proto_descriptor_sets_include_source_info to work. See: bufbuild/rules_buf#64 (comment)

Many of these changes mirror bufbuild/rules_buf#80, and I suspect adding them here as well will save a lot of folks needing to dive a layer down to figure out how to configure buf correctly.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Manual testing; please provide instructions so we can reproduce: I'm guessing the behavior of the example directory is tested manually. To test, I suggest modifying the items in example/buf.yaml and the comment ignores in example/src/file.proto and verifying they behave as expected.

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat thanks!

FYI @perezd - I suspect a lot of Bazelers will use Buf via this ruleset, and maybe you'd like to reduce the ambition of rules_buf if you can avoid maintaining formatting&linting support

example/MODULE.bazel Outdated Show resolved Hide resolved
example/buf.yaml Outdated Show resolved Hide resolved
example/lint.sh Outdated Show resolved Hide resolved
@perezd
Copy link

perezd commented Jul 8, 2024

Yeah, we would like to not maintain that. Sounds good to us!

@SpencerC SpencerC requested a review from alexeagle July 8, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants