Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated mkdirp dependency #204

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Remove deprecated mkdirp dependency #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"hash-for-dep": "^1.5.0",
"heimdalljs": "^0.2.1",
"heimdalljs-logger": "^0.1.7",
"mkdirp": "^0.5.1",
"promise-map-series": "^0.2.1",
"rimraf": "^3.0.0",
"symlink-or-copy": "^1.0.1",
Expand All @@ -59,19 +58,19 @@
"@types/rimraf": "^3.0.0",
"broccoli-node-api": "^1.7.0",
"broccoli-test-helper": "^2.0.0",
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"chai-files": "^1.4.0",
"chai": "^4.2.0",
"co": "^4.6.0",
"coveralls": "^3.0.9",
"dtslint": "^3.4.1",
"fs-merger": "^3.1.0",
"istanbul": "^0.4.2",
"minimatch": "^3.0.2",
"mocha-jshint": "^2.3.1",
"mocha": "^7.1.1",
"sinon-chai": "^3.1.0",
"mocha-jshint": "^2.3.1",
"sinon": "^7.5.0",
"sinon-chai": "^3.1.0",
"source-map-support": "^0.5.16",
"typescript": "^3.8.3"
},
Expand Down
4 changes: 1 addition & 3 deletions test/filter-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ chai.use(chaiFiles);
const sinon = require('sinon');

const fs = require('fs');
const mkdirp = require('mkdirp');
const path = require('path');
const Filter = require('..');
const rimraf = require('rimraf').sync;
Expand All @@ -41,7 +40,7 @@ describe('Filter', function() {
function write(relativePath, contents, _encoding) {
let encoding = _encoding === undefined ? 'utf8' : _encoding;

mkdirp.sync(path.dirname(relativePath));
fs.mkdirSync(path.dirname(relativePath), { recursive: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I actually don't think this is allowed in our current engines range. We specify support for 10.0.0 (via 10.* in engines), but this API was not added until 10.12.0.

Since this is only used in tests, I think it doesn't really matter too much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought, 10.12 came out almost 2 years ago so hopefully something only used in tests wouldn't need to work that far back.

fs.writeFileSync(relativePath, contents, {
encoding
});
Expand Down Expand Up @@ -1613,4 +1612,3 @@ describe('throttling', function() {
});

});