Remove deprecated mkdirp dependency
#204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0.5 version is deprecated. As this was only used in tests and isn't needed in recent node 10.x releases I replaced it's use in the test and removed the package.
rwjblue
approved these changes
Jul 26, 2020
| @@ -41,7 +40,7 @@ describe('Filter', function() { | |||
| function write(relativePath, contents, _encoding) { | |||
| let encoding = _encoding === undefined ? 'utf8' : _encoding; | |||
|
|
|||
| mkdirp.sync(path.dirname(relativePath)); | |||
| fs.mkdirSync(path.dirname(relativePath), { recursive: true }); | |||
There was a problem hiding this comment.
FYI - I actually don't think this is allowed in our current engines range. We specify support for 10.0.0 (via 10.* in engines), but this API was not added until 10.12.0.
Since this is only used in tests, I think it doesn't really matter too much.
There was a problem hiding this comment.
That's what I thought, 10.12 came out almost 2 years ago so hopefully something only used in tests wouldn't need to work that far back.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.5 version is deprecated. As this was only used in tests and isn't needed in recent node 10.x
releases I replaced it's use in the test and removed the package.