Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing documentation for viral-pipelines #461

Merged
merged 51 commits into from
Jul 19, 2023
Merged

Enhancing documentation for viral-pipelines #461

merged 51 commits into from
Jul 19, 2023

Conversation

golu099
Copy link
Contributor

@golu099 golu099 commented Mar 30, 2023

Adding documentation to important input/ouput parameters for some of the more used workflows in the pipeline (assembled_refbased, demux_deplete,classify_single, augur_from_assemblies, and genbank.

Additionally orphan workflows will be noted.

@golu099 golu099 marked this pull request as ready for review April 11, 2023 06:05
Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few housekeeping requests -- haven't dug into content yet

pipes/WDL/workflows/16S_train_classifier.wdl Outdated Show resolved Hide resolved
@@ -0,0 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file from the branch and perhaps add .vscode/ to the .gitignore file instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments

docs/workflows.rst Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Show resolved Hide resolved
pipes/WDL/workflows/assemble_refbased.wdl Show resolved Hide resolved
@dpark01
Copy link
Member

dpark01 commented Apr 13, 2023

One quick note: I went into readthedocs and activated automatic public builds of the fnegrete_test branch so we can check there for how things render as you edit this PR.

See here for rendered output: https://viral-pipelines.readthedocs.io/en/fnegrete_test/

See here for build status (right now it's succeeding so nothing to see here, but if for some reason you had a syntax error or something, you'd see failures here): https://readthedocs.org/projects/viral-pipelines/builds/

golu099 and others added 3 commits April 13, 2023 14:13
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/workflows/demux_deplete.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_16S_amplicon.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_assembly.wdl Outdated Show resolved Hide resolved
golu099 and others added 13 commits May 2, 2023 09:50
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
Co-authored-by: Daniel Park <dpark@broadinstitute.org>
@golu099 golu099 closed this May 19, 2023
@golu099 golu099 reopened this May 19, 2023
@golu099
Copy link
Contributor Author

golu099 commented May 19, 2023

Did we merge this? Should I keep it open for future documentation fixes?

@golu099
Copy link
Contributor Author

golu099 commented Jul 18, 2023

amplicon16S analysis wdl renamed to classify_qiime2_multi

Noticed that the old name is on the master branch still, so we should updated this

cateogry: "advanced"
}
min_length: {
description: "Minimum length of the read, cutadapt will discard anything that is shorter than n bp AFTER trimming.Set to default.",
Copy link
Member

@tomkinsc tomkinsc Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whose default? qiime's? cutadapt's? Maybe specify the source of the default and/or its value here. Also maybe specify that it would be reads that would be discarded: "discard anything that is" -> "discard reads that are". If such reads are discarded, does that extend to both reads of a pair for paired-end sequencing, or could it toss one read and keep its mate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this small change, let's get this merged in.

cateogry: "advanced"
}
min_length: {
description: "Minimum length of the read, cutadapt will discard anything that is shorter than n bp AFTER trimming.Set to default.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this small change, let's get this merged in.

@tomkinsc tomkinsc merged commit f7d784f into master Jul 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants