Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-cloud-nio to support underscores in bucket names #8439

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

kshakir
Copy link
Contributor

@kshakir kshakir commented Jul 26, 2023

No description provided.

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming the test case you added fails with the previous version of the NIO library.

@kshakir
Copy link
Contributor Author

kshakir commented Jul 26, 2023

@droazen I may also have to bump the shadowJar library... investigating...

@droazen
Copy link
Contributor

droazen commented Jul 26, 2023

@kshakir Yes, something is compiled for Java 19 (we are on 17)...

@gatk-bot
Copy link

gatk-bot commented Jul 26, 2023

Github actions tests reported job failures from actions build 5673591869
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5673591869.10 logs
integration 17.0.6+10 5673591869.11 logs

@kshakir kshakir marked this pull request as draft July 27, 2023 00:50
@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5675230266
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5675230266.10 logs
integration 17.0.6+10 5675230266.11 logs

@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5675309053
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5675309053.10 logs
integration 17.0.6+10 5675309053.11 logs

@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5675450808
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5675450808.10 logs
integration 17.0.6+10 5675450808.11 logs

@lbergelson
Copy link
Member

You are currently running with version 2.2.0 of google-api-client. You need at least version 1.31.1 of google-api-client to run version 1.32.1 of the BigQuery API library.

@kshakir kshakir force-pushed the ks_bump_gcs_nio branch 2 times, most recently from ee3a8ca to 0b8185d Compare July 27, 2023 02:24
@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5675759702
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5675759702.10 logs
integration 17.0.6+10 5675759702.11 logs

@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5675841383
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5675841383.10 logs
integration 17.0.6+10 5675841383.11 logs

@kshakir
Copy link
Contributor Author

kshakir commented Jul 27, 2023

This PR is on hold until Picard is updated to use the new google libs: broadinstitute/picard#1903

@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5677288686
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 5677288686.10 logs
integration 17.0.6+10 5677288686.11 logs
integration 17.0.6+10 5677288686.0 logs

@kshakir kshakir force-pushed the ks_bump_gcs_nio branch 2 times, most recently from b13eb98 to 3daa6ce Compare July 27, 2023 07:14
@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5677548223
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 17.0.6+10 5677548223.11 logs
integration 17.0.6+10 5677548223.0 logs

@gatk-bot
Copy link

gatk-bot commented Jul 27, 2023

Github actions tests reported job failures from actions build 5677658199
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 17.0.6+10 5677658199.11 logs
integration 17.0.6+10 5677658199.0 logs

@kshakir
Copy link
Contributor Author

kshakir commented Jul 28, 2023

Tests are passing using a snapshot generated while debugging broadinstitute/picard#1904

Folks can review and give feedback. Perhaps we shouldn't merge though unless referencing a library SNAPSHOT is ok or picard 3.0.1 is released.

@kshakir kshakir marked this pull request as ready for review July 28, 2023 17:16
@kshakir
Copy link
Contributor Author

kshakir commented Jul 28, 2023

Tests now running with the Picard 3.1.0 release

@kshakir kshakir requested a review from droazen July 28, 2023 17:16
@kshakir kshakir requested a review from lbergelson July 28, 2023 17:17
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me @kshakir , but I recommend asking @lbergelson to take a look at the build.gradle changes as well.

@kshakir
Copy link
Contributor Author

kshakir commented Aug 1, 2023

Force pushed an update using a freshly released guava which no longer requires pinning mockito.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kshakir L_G_T_M

@lbergelson
Copy link
Member

Thank you @kshakir

@lbergelson lbergelson merged commit ee4d095 into master Aug 1, 2023
@lbergelson lbergelson deleted the ks_bump_gcs_nio branch August 1, 2023 22:04
rickymagner pushed a commit that referenced this pull request Nov 28, 2023
* Update gradle to 8.2.1
* Update various dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants