-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-cloud-nio to support underscores in bucket names #8439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, assuming the test case you added fails with the previous version of the NIO library.
@droazen I may also have to bump the shadowJar library... investigating... |
@kshakir Yes, something is compiled for Java 19 (we are on 17)... |
Github actions tests reported job failures from actions build 5673591869
|
Github actions tests reported job failures from actions build 5675230266
|
Github actions tests reported job failures from actions build 5675309053
|
Github actions tests reported job failures from actions build 5675450808
|
|
ee3a8ca
to
0b8185d
Compare
Github actions tests reported job failures from actions build 5675759702
|
Github actions tests reported job failures from actions build 5675841383
|
This PR is on hold until Picard is updated to use the new google libs: broadinstitute/picard#1903 |
Github actions tests reported job failures from actions build 5677288686
|
b13eb98
to
3daa6ce
Compare
Github actions tests reported job failures from actions build 5677548223
|
Github actions tests reported job failures from actions build 5677658199
|
fb19bc9
to
58bbc59
Compare
Tests are passing using a snapshot generated while debugging broadinstitute/picard#1904 Folks can review and give feedback. Perhaps we shouldn't merge though unless referencing a library SNAPSHOT is ok or picard 3.0.1 is released. |
Tests now running with the Picard 3.1.0 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me @kshakir , but I recommend asking @lbergelson to take a look at the build.gradle
changes as well.
fd9d2a7
to
de66200
Compare
Force pushed an update using a freshly released guava which no longer requires pinning mockito. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kshakir L_G_T_M
Thank you @kshakir |
* Update gradle to 8.2.1 * Update various dependencies
No description provided.