Batch population of alt_allele table from vet_ tables [VS-265] #7998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #7998 +/- ##
================================================
Coverage ? 86.241%
Complexity ? 35196
================================================
Files ? 2173
Lines ? 165016
Branches ? 17793
================================================
Hits ? 142311
Misses ? 16378
Partials ? 6327 |
mcovarr
approved these changes
Aug 24, 2022
| @@ -232,6 +250,6 @@ task PopulateAltAlleleTable { | |||
| } | |||
|
|
|||
| output { | |||
| String done = "~{vet_table_name}" | |||
| String done = "~{sep=' ' vet_table_names}" | |||
There was a problem hiding this comment.
I've been using done as a boolean to indicate when the call is done so tasks dependent on side effects will know when to run. It seems this is actually a different concept, whitespace separated vet table names.
|
PR reviewed in mob 8/24/22, additional 👍🏻s are implied |
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by:
GvsAssignIdsworkflowsample_idsto span from 1 to 15535vet_002,vet_003,vet_004,ref_ranges_002,ref_ranges_003,ref_ranged_004tablesGvsImportGenomesworkflowGvsPopulateAltAlleleworkflow withmax_alt_allele_shardsto 3 so that it would divide the vet tables into (at most) 3 filessee https://app.terra.bio/#workspaces/gvs-dev/RSA%20-%20GVS%20Quickstart%20V2%20/job_history/b1b319bc-a2aa-44cb-ad9a-079b7c1c33de for
GvsPopulateAltAllelerun