Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put withdrawn sample data in alt_allele table [VS-369] #7762

Merged
merged 8 commits into from
Apr 8, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Apr 6, 2022

@rsasch rsasch marked this pull request as draft April 6, 2022 19:55
@rsasch rsasch marked this pull request as ready for review April 7, 2022 00:02
@rsasch
Copy link
Author

rsasch commented Apr 8, 2022

Ran tests with JOIN query vs. IN query and performance/bytes scanned appeared identical. Going with IN query because it's more readable (to me, at least).

@rsasch rsasch requested review from kcibul and mcovarr April 8, 2022 13:19
@rsasch rsasch merged commit 6bf03de into ah_var_store Apr 8, 2022
@rsasch rsasch deleted the rsa_alt_allele_withdrawn branch April 8, 2022 16:36
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants