Now correctly populates transcript position. #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the transcript position would always only be the start position
of the variant in the transcript.
The transcript position field should contain either a single number (for
SNPS) or two numbers separated by an underscore representing the
transcript start and stop positions of the variant.
This fix correctly changes the field to include both start and stop
positions when start != stop.
Fixes #5375
jonn-smith
force-pushed
the
jts_tx_position_fix_5375
branch
from
eac227e to
397d3a5
Compare
LeeTL1220
approved these changes
Oct 31, 2018
EdwardDixon
pushed a commit
to EdwardDixon/gatk
that referenced
this pull request
Nov 9, 2018
* Now correctly populates transcript position.
Before the transcript position would always only be the start position
of the variant in the transcript.
The transcript position field should contain either a single number (for
SNPS) or two numbers separated by an underscore representing the
transcript start and stop positions of the variant.
This fix correctly changes the field to include both start and stop
positions when start != stop.
Fixes broadinstitute#5375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the transcript position would always only be the start position
of the variant in the transcript.
The transcript position field should contain either a single number (for
SNPS) or two numbers separated by an underscore representing the
transcript start and stop positions of the variant.
This fix correctly changes the field to include both start and stop
positions when start != stop.
Fixes #5375