Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to htsjdk 2.14.1 #4210

Merged
merged 1 commit into from
Jan 19, 2018
Merged

updating to htsjdk 2.14.1 #4210

merged 1 commit into from
Jan 19, 2018

Conversation

lbergelson
Copy link
Member

htsjdk 2.13.2 -> 2.14.1

htsjdk 2.13.2 -> 2.14.1
@cmnbroad
Copy link
Collaborator

@lbergelson The old File SequenceDictionaryExtractor methods are still there right ? If not we should upgrade picard as well.

@lbergelson
Copy link
Member Author

They're still there, just deprecated.

@cmnbroad
Copy link
Collaborator

Looks like these were just deprecated, so they should be ok. 👍 when tests pass.

@codecov-io
Copy link

Codecov Report

Merging #4210 into master will decrease coverage by 0.007%.
The diff coverage is 33.333%.

@@              Coverage Diff               @@
##              master    #4210       +/-   ##
==============================================
- Coverage     78.477%   78.47%   -0.007%     
+ Complexity     16424    16423        -1     
==============================================
  Files           1041     1041               
  Lines          59099    59099               
  Branches        9673     9673               
==============================================
- Hits           46379    46375        -4     
- Misses          8978     8981        +3     
- Partials        3742     3743        +1
Impacted Files Coverage Δ Complexity Δ
...llbender/utils/test/SimpleIntervalTestFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...kers/variantutils/UpdateVCFSequenceDictionary.java 86.957% <100%> (ø) 14 <0> (ø) ⬇️
...e/hellbender/engine/spark/SparkContextFactory.java 71.233% <0%> (-2.74%) 11% <0%> (ø)
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 78.71% <0%> (-1.29%) 39% <0%> (ø)
...park/sv/discovery/alignment/AlignmentInterval.java 89.272% <0%> (-0.383%) 73% <0%> (-1%)
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+10%) 3% <0%> (ø) ⬇️

@lbergelson lbergelson merged commit 280be4e into master Jan 19, 2018
@lbergelson lbergelson deleted the lb_update_to_htsjdk_2.14.1 branch January 19, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants