removing required FASTA reference input in SV discovery pipeline #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3673 +/- ##
==============================================
+ Coverage 79.394% 79.41% +0.016%
Complexity 17371 17371
==============================================
Files 1139 1139
Lines 62685 62681 -4
Branches 9526 9526
==============================================
+ Hits 49768 49775 +7
+ Misses 9120 9109 -11
Partials 3797 3797
|
SHuang-Broad
force-pushed
the
sh_sv_drop_required_refFASTA
branch
from
0a96f0f to
ed0ebc5
Compare
|
@TedBrookings will you be willing to take a look? |
|
Yeah, I've done a quick skim and it looks like I should be able to review. |
|
Thanks! |
| } | ||
|
|
||
| } | ||
|
|
||
| @DataProvider(name = "discoverVariantsFromContigAlignmentsSparkIntegrationTest") | ||
| public Object[][] createTestData() throws IOException { |
There was a problem hiding this comment.
Maybe due to my lack of java knowledge, but why was the "throws IOException" removed?
There was a problem hiding this comment.
For record keeping: my version of IDE indicates the function (or actually the function it calls into) now doesn't throw IOException any more, so I removed it.
TedBrookings
approved these changes
Oct 12, 2017
…ts dict) for sorting variants in output VCF, now using header in input SAM/BAM
SHuang-Broad
force-pushed
the
sh_sv_drop_required_refFASTA
branch
from
1fa9e6e to
5b32bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for its dict) for sorting variants in output VCF, now using header in input SAM/BAM