Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug causing error finding ref base for imprecise deletions #3671

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

cwhelan
Copy link
Member

@cwhelan cwhelan commented Oct 6, 2017

This PR fixes a critical error that was causing an "invalid interval" exception to be thrown while calling imprecise deletion intervals. The problem was a mismatch between the sequence dictionary in the reference and the read metadata's contig ID - contig name mapping. I've modified the code to always use the read metadata when translating the contig ID in EvidenceTargetLink intervals into contig names.

@cwhelan
Copy link
Member Author

cwhelan commented Oct 6, 2017

@tedsharpe this should fix your error on NA12878; I just ran that sample through without hitting an exception with this code change. Want to take a look at the changes?

Copy link
Contributor

@tedsharpe tedsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov-io
Copy link

Codecov Report

Merging #3671 into master will increase coverage by 0.035%.
The diff coverage is 91.667%.

@@               Coverage Diff               @@
##              master     #3671       +/-   ##
===============================================
+ Coverage     79.266%   79.301%   +0.035%     
- Complexity     17397     17412       +15     
===============================================
  Files           1144      1144               
  Lines          62931     63048      +117     
  Branches        9551      9580       +29     
===============================================
+ Hits           49883     49998      +115     
+ Misses          9241      9233        -8     
- Partials        3807      3817       +10
Impacted Files Coverage Δ Complexity Δ
...s/spark/sv/discovery/AnnotatedVariantProducer.java 74.79% <100%> (ø) 23 <1> (ø) ⬇️
...ute/hellbender/tools/spark/sv/utils/SVContext.java 76.033% <100%> (ø) 21 <0> (ø) ⬇️
...lbender/tools/spark/sv/discovery/SimpleSVType.java 86.567% <100%> (ø) 2 <0> (ø) ⬇️
.../DiscoverVariantsFromContigAlignmentsSAMSpark.java 93.478% <80%> (-1.027%) 24 <5> (+1)
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 79.87% <0%> (+1.299%) 39% <0%> (ø) ⬇️
.../hellbender/tools/genomicsdb/GenomicsDBImport.java 81.432% <0%> (+7.103%) 68% <0%> (+14%) ⬆️

@cwhelan cwhelan merged commit 1e7c342 into master Oct 6, 2017
@cwhelan cwhelan deleted the cw_invalid_imprecise_del_ref_base branch October 25, 2017 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants