Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames StructuralVariantContext to SVContext. #3617

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Conversation

vruano
Copy link
Contributor

@vruano vruano commented Sep 26, 2017

This is more in-line with other SV class names.

Also SVContext.create is renamed to SVContext.of

This is more in-line with other SV classe names.

Also SVContext.create is renamed to SVContext.of
@vruano
Copy link
Contributor Author

vruano commented Sep 26, 2017

@SHuang-Broad just a simple class rename and a method rename, so basically this just about whether you agree.

@vruano vruano added the SV label Sep 26, 2017
@codecov-io
Copy link

Codecov Report

Merging #3617 into master will increase coverage by 0.004%.
The diff coverage is 33.333%.

@@              Coverage Diff               @@
##              master    #3617       +/-   ##
==============================================
+ Coverage     79.766%   79.77%   +0.004%     
  Complexity     18233    18233               
==============================================
  Files           1224     1224               
  Lines          66966    66966               
  Branches       10449    10449               
==============================================
+ Hits           53416    53419        +3     
+ Misses          9327     9324        -3     
  Partials        4223     4223
Impacted Files Coverage Δ Complexity Δ
...ute/hellbender/tools/spark/sv/utils/SVContext.java 74.286% <33.333%> (ø) 19 <1> (?)
...e/hellbender/engine/spark/SparkContextFactory.java 71.233% <0%> (-2.74%) 11% <0%> (ø)
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 79.87% <0%> (+3.247%) 39% <0%> (ø) ⬇️

@SHuang-Broad
Copy link
Contributor

I like it. 👍

@vruano vruano merged commit 61542a0 into master Sep 27, 2017
@vruano vruano deleted the vrr_svcontext_rename branch September 27, 2017 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants