Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aligned PathSeq input getting filtered by WellformedReadFilter #3453

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

mwalker174
Copy link
Contributor

PathSeqFilterSpark and PathSeqPipelineSpark clear all the sequences from the input header file, as the Bwa step only accepts unaligned reads. However, the header sequences were being cleared before the reads were loaded, causing WellformedReadFilter to remove any mapped reads (by failing to find the corresponding sequence name in the header).

This PR fixes this bug by creating a deep copy of the header. It also refactors this code, which is used in both the Filter and Pipeline tools, into a utility function checkAndClearHeaderSequences() in PSUtils. Tests have also been added/updated accordingly.

@codecov-io
Copy link

Codecov Report

Merging #3453 into master will increase coverage by 0.008%.
The diff coverage is 75%.

@@              Coverage Diff               @@
##              master    #3453       +/-   ##
==============================================
+ Coverage     80.522%   80.53%   +0.008%     
- Complexity     17612    17613        +1     
==============================================
  Files           1176     1176               
  Lines          63617    63617               
  Branches        9903     9901        -2     
==============================================
+ Hits           51226    51231        +5     
+ Misses          8435     8432        -3     
+ Partials        3956     3954        -2
Impacted Files Coverage Δ Complexity Δ
...bender/tools/spark/pathseq/PathSeqFilterSpark.java 80.769% <100%> (+9.801%) 5 <0> (-2) ⬇️
...nder/tools/spark/pathseq/PathSeqPipelineSpark.java 89.474% <100%> (+5.603%) 7 <0> (ø) ⬇️
...titute/hellbender/tools/spark/pathseq/PSUtils.java 75% <70%> (-2.778%) 15 <3> (+3)

Copy link
Contributor

@SHuang-Broad SHuang-Broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@SHuang-Broad SHuang-Broad removed their assignment Aug 17, 2017
@mwalker174 mwalker174 merged commit 3312952 into master Aug 21, 2017
@mwalker174 mwalker174 deleted the mw_filter_header branch August 21, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants