Reenable IndexFeatureFile. #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnbroad
force-pushed
the
cn_reenable_index_feature_file
branch
2 times, most recently
from
29dfe2b to
6f8f5d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3425 +/- ##
==============================================
+ Coverage 80.287% 80.35% +0.063%
- Complexity 17633 17654 +21
==============================================
Files 1178 1178
Lines 63847 63857 +10
Branches 9928 9928
==============================================
+ Hits 51261 51309 +48
+ Misses 8631 8586 -45
- Partials 3955 3962 +7
|
cmnbroad
force-pushed
the
cn_reenable_index_feature_file
branch
from
6f8f5d4 to
1724065
Compare
cmnbroad
force-pushed
the
cn_reenable_index_feature_file
branch
from
1724065 to
efdd3db
Compare
lbergelson
approved these changes
Aug 14, 2017
There was a problem hiding this comment.
@cmnbroad Looks good to me. One comment but feel free to ignore it.
| while (originalIterator.hasNext()) { | ||
| final VariantContext originalVC = originalIterator.next(); | ||
| final Iterator<VariantContext> indexedIterator = indexedSource.query( | ||
| new SimpleInterval( |
There was a problem hiding this comment.
there's a constructor directly from another locatable if you want to save a few characters
There was a problem hiding this comment.
I'll take it. Done.
cmnbroad
force-pushed
the
cn_reenable_index_feature_file
branch
from
efdd3db to
1bb7254
Compare
jonn-smith
pushed a commit
that referenced
this pull request
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2801 and #3060. Requires new htsjdk (which requires #3403).