Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle annotation-related arguments into an ArgumentCollection #3292

Closed
droazen opened this issue Jul 17, 2017 · 1 comment
Closed

Bundle annotation-related arguments into an ArgumentCollection #3292

droazen opened this issue Jul 17, 2017 · 1 comment
Assignees
Milestone

Comments

@droazen
Copy link
Contributor

droazen commented Jul 17, 2017

Currently tools using the annotation engine are manually defining arguments to control which annotations should be enabled/disabled. See HaplotypeCallerArgumentCollection annotationsToUse/annotationGroupsToUse for an example. We should bundle these into a reusable argument collection, like we did for read filters, as part of the task of making annotations a barclay plugin.

@magicDGS
Copy link
Contributor

It will be very useful to have an abstract class for the plugin arguments (as I did for the read filters plugin in #2355) to be able for downstream projects to change default values or hide arguments to the final user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants