Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-1885 Fix Bard default behavior #7566

Merged
merged 1 commit into from
Sep 30, 2024
Merged

WX-1885 Fix Bard default behavior #7566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ services {
}
}
// Bard is used for metrics collection in the Terra SaaS offering and is not applicable outside of it.
Bard {
BardEventing {
class = "cromwell.services.metrics.bard.impl.BardEventingActor"
config {
enabled = false
Expand Down
1 change: 1 addition & 0 deletions services/src/main/scala/cromwell/services/metrics/bard/impl/BardEventingActor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

override def receive: Receive = {
case BardEventRequest(event) if bardConfig.enabled => bardService.sendEvent(event)
case BardEventRequest(_) => // do nothing if Bard not enabled

Check warning on line 27 in services/src/main/scala/cromwell/services/metrics/bard/impl/BardEventingActor.scala

View check run for this annotation

Codecov / codecov/patch

services/src/main/scala/cromwell/services/metrics/bard/impl/BardEventingActor.scala#L27 

Added line #L27 was not covered by tests
// This service currently doesn't do any work on shutdown but the service registry pattern requires it
// (see https://github.com/broadinstitute/cromwell/issues/2575)
case ShutdownCommand => context stop self
Expand Down
Loading