Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-1885 Fix Bard default behavior #7566

Merged
merged 1 commit into from
Sep 30, 2024
Merged

WX-1885 Fix Bard default behavior #7566

merged 1 commit into from
Sep 30, 2024

Conversation

jgainerdewar
Copy link
Collaborator

@jgainerdewar jgainerdewar commented Sep 30, 2024 •
edited
Loading

Description

This should have no effect on our existing Bard usage, just removes errors logged when NOT using Bard.

  • Base config was incorrect, so Bard was not registered in the Service Registry by default
  • BardEventingActor.receive had no handling for receiving a BardEvent when eventing was disabled... and also nothing has ever checked for enablement before creating and sending these events.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@jgainerdewar jgainerdewar requested a review from a team as a code owner September 30, 2024 19:21
@jgainerdewar jgainerdewar merged commit e54b32e into develop Sep 30, 2024
39 checks passed
@jgainerdewar jgainerdewar deleted the jd_WX-1885_fixBardDefaults branch September 30, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aednichols aednichols aednichols approved these changes

@salonishah11 salonishah11 salonishah11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgainerdewar @aednichols @salonishah11