Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session List #3132

Merged
merged 28 commits into from
Aug 15, 2024
Merged

Session List #3132

merged 28 commits into from
Aug 15, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Jul 18, 2024

Added a sessions pane in the left sidebar.

Whenever a new query tab is created, a new entry will be added to the list of sessions. When the tab is closed, the session entry will remain. When the session is clicked, it will either activate the associated tab if it exists, or it will restore that tab, along with it's history. You can right click a session to delete it. Deleting it will destroy the associated tab and history.

The display name of the tab is text of the most recent query in that sessions history.

  • Make Sessions Global
  • Migrate sessions and session history
  • Fix the "query pool" not using the proper "create session" flow

Fixes #2746
Closes #2467

@jameskerr jameskerr requested a review from philrz July 22, 2024 18:32
@philrz

This comment was marked as resolved.

@philrz
Copy link
Contributor

philrz commented Aug 8, 2024

I'm currently testing this branch at commit 0babafa.

This is a fairly small thing I noticed during testing. It's not the easiest to trigger, but the attached video and steps below seem to trigger it reliably.

  1. Load some data
  2. Click to the Sessions list in the left panel
  3. Close the pool page for the data just added
  4. Start one Session and run a count() on the pool
  5. Start a second session and run a search (e.g., google) on the pool
  6. Right-click and delete the Session with count() from the list

An empty slot is left behind for the deleted tab. This empty slot is filled in as soon as I click another tab. I'm guessing we'd have wanted the tab slots to tighten up as soon as the Session was deleted.

Repro.mp4

@philrz

This comment was marked as resolved.

Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the fix of two issues I previously reported on this branch and haven't noticed any new problems, so I'm 👍 on it. @jameskerr and I discussed offline that the "tab bug" described in #3132 (comment) will be addressed in a follow-on PR after this one merges.

@jameskerr jameskerr merged commit aa15e3e into main Aug 15, 2024
4 checks passed
@jameskerr jameskerr deleted the session-list branch August 15, 2024 22:48
This was referenced Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing the Details window last causes loss of Session history First Class Sessions
2 participants