Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the Details window last causes loss of Session history #2746

Closed
philrz opened this issue Apr 1, 2023 · 1 comment · Fixed by #3132
Closed

Closing the Details window last causes loss of Session history #2746

philrz opened this issue Apr 1, 2023 · 1 comment · Fixed by #3132
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Apr 1, 2023

Repro is with Zui Insiders v1.0.2-1, which is based on Zui commit f2bce04.

As pointed out in #2743 (review), the fix to #2730 reveals a second order issue. As shown in the attached video, if the Search window is closed first and then the Details window after, the Session history is gone when the app is relaunched.

Repro.mp4
@philrz
Copy link
Contributor Author

philrz commented Aug 17, 2024

Verified in Zui Insiders 1.17.1-insiders.11 which is based on Zui commit d3a0402.

As shown in the attached video, now if the Detail window is closed last, the History of the previous Query Session can still be found and restored from under the new Sessions tab.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants