Fix History Back, Push Bugs #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-fish
approved these changes
Feb 11, 2021
| @@ -25,10 +25,11 @@ const StyledInput = styled.input` | |||
| outline: none; | |||
| } | |||
| ` | |||
| // create a tiny little history closure | |||
There was a problem hiding this comment.
Is this comment referring to this component or just a leftover note to self?
There was a problem hiding this comment.
A left over note to self!
jameskerr
commented
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1331
There were 3 implementations of a History class in the app:
This PR creates a single
app/core/models/history.tswhich is used in all the places the above 3 classes were used.The bug was ins the "push" method of both
LogDetailHistory.tsandInputHistory.ts. It did not properly "splice" the new record at the correct position, then delete all following entries. It simply "pushed" a new entry onto the array. Thebrim/entries.tsimplementation did have it correct.In the first commit I create a failing test that reproduces the bug.
To Do: