Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Back" button is not returning to previously-viewed record #1331

Closed
philrz opened this issue Jan 6, 2021 · 1 comment · Fixed by #1447
Closed

"Back" button is not returning to previously-viewed record #1331

philrz opened this issue Jan 6, 2021 · 1 comment · Fixed by #1447
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Jan 6, 2021

Repro is with Brim commit 803b151 and with test pcap https://archive.wrccdc.org/pcaps/2018/wrccdc.2018-03-23.010014000000000.pcap.gz (uncompress before import). It does look like this is not a new bug, though, as I was able to repro in Brim GA tagged v0.21.1 as well.

Per the attached video, repro steps:

  1. Start by searching for "C1md9p1UxupPOvCs9f" and bring up the conn record in the Log Detail window
  2. Click the tile for the first http event and then click the Back button. I'm brought back to the conn event as expected.
  3. Click the the tile for the first files event and then click the Back button. At that point I expected to be brought back to the conn event again since it's what was just displayed. Instead the Back button brings me back to the http event, so I need to click Back yet again to get back to the original conn event.
  4. If I click to other tiles, it seems to only increase the "stack" of additional events I have to click through via Back to return all the way to the original conn I'd started at.
Repro.mov
@philrz philrz added the bug Something isn't working label Jan 6, 2021
@philrz philrz added this to the Brim v0.24.0 milestone Jan 28, 2021
@alfred-landrum alfred-landrum modified the milestones: Brim v0.24.0, Brim v0.25.0 Feb 2, 2021
@philrz
Copy link
Contributor Author

philrz commented Feb 12, 2021

Verified in a nightly Brim build based on commit 226ef3b3.

Repeating the repro steps as shown in the attached video, now each time the "back" button is clicked, we go directly back to the conn record we were looking at previously.

Verify.mov

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants