Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare(): return error when error is encountered #5663

Merged
merged 1 commit into from
Feb 19, 2025
Merged

compare(): return error when error is encountered #5663

merged 1 commit into from
Feb 19, 2025

Conversation

mattnibs
Copy link
Collaborator

No description provided.

nwt
nwt approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add test coverage for this in runtime/sam/expr/function/ztests/compare.yaml.

@mattnibs mattnibs merged commit 7a3ef94 into main Feb 19, 2025
3 checks passed
@mattnibs mattnibs deleted the compare-error branch February 19, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattnibs @nwt