compare(): return error when error is encountered

brimdata · Feb 19, 2025 · 4c6b6e8 · 4c6b6e8
1 parent 79a220d
commit 4c6b6e8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/runtime/sam/expr/function/compare.go b/runtime/sam/expr/function/compare.go
@@ -28,6 +28,12 @@ func (e *Compare) Call(_ super.Allocator, args []super.Value) super.Value {
 		}
 		nullsMax = args[2].Bool()
 	}
+	if args[0].IsError() {
+		return args[0]
+	}
+	if args[1].IsError() {
+		return args[1]
+	}
 	cmp := e.nullsMax
 	if !nullsMax {
 		cmp = e.nullsMin

diff --git a/runtime/sam/expr/function/ztests/compare.yaml b/runtime/sam/expr/function/ztests/compare.yaml
@@ -5,9 +5,13 @@ input: |
   {a: 2, b: "1"}
   {a: null, b: 2}
   {a: 0, b: 0.}
+  {a: 0}
+  {b: 0}
 
 output: |
   1
   -1
   1
   0
+  error("missing")
+  error("missing")