Add *-apple-{visionos,watchos} support; CI: build tvOS,visionOS,watchOS. #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
=======================================
Coverage 97.07% 97.08%
=======================================
Files 144 144
Lines 20124 20124
Branches 456 456
=======================================
+ Hits 19535 19537 +2
Misses 492 492
+ Partials 97 95 -2 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/apple-targets
branch
8 times, most recently
from
429ce5c
to
6e06cf8
Compare
briansmith
changed the title
|
Note that this might cause some large tables to be added to the build for P-256 and X25519 that weren't included before, which could significantly bloat the size of the app. This might be especially concerning for watchOS applications. We may want to merge BoringSSL's https://boringssl.googlesource.com/boringssl/+/20c9406971b39d214d4d6997f3a6e3ec772c440a to address this. |
This was referenced Jun 20, 2024
briansmith
force-pushed
the
b/apple-targets
branch
12 times, most recently
from
21c0631
to
0e22316
Compare
Change visionOS and watchOS to use the assembly implementations like iOS, macOS, and tvOS were already. The large tables for P-256 and Curve25519 probably aren't appropriate for watchOS; that will be addressed later, maybe by merging BoringSSL commit 20c9406. Use the same C compiler options for all these targets.
briansmith
force-pushed
the
b/apple-targets
branch
from
0e22316
to
1b8f998
Compare
|
Looks good, just be careful with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.