Add Apple visionOS support

[QuentinPerez]

Motivation

Add the support of Apple VisionOS 121419

Solution

Add target_os = "visionos"

[briansmith]

Thanks for this. Have you tested this on visionOS hardware and in the simulator?

[QuentinPerez]

Thank you for the review. It's clearer now how ring works. The change is much simpler! And yes, I tested it; the app is even on the App Store :) .

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (be4ba83) to head (193bb7c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   97.24%   97.35%   +0.10%     
==========================================
  Files         144      142       -2     
  Lines       19998    19915      -83     
  Branches      228      228              
==========================================
- Hits        19447    19388      -59     
+ Misses        525      500      -25     
- Partials       26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sax]

Hello! I'm curious if this same change would be required to add support for watchos.

[briansmith]

@QuentinPerez could you please rebase this on top of the latest changes on the main branch. The recent changes should result in it being even simpler now.

[briansmith]

Hello! I'm curious if this same change would be required to add support for watchos.

There are several watchos targets, some of which are easier to support than others. PR #1914 started to add support for watchOS, but it got closed before it was finished. I suggest you pick where that left off.

[briansmith]

What is the oldest cc-rs that is known to work for this? Because of issues like rust-lang/cc-rs#984 I'm weary of forcing users to update to too-new version of cc-rs right now, if we can avoid it.

[sax]

VisionOS support was added in 1.0.93, but 1.0.94 includes a fix to how it integrates with xcrun that may be necessary. I don't see anything in the changelog after 1.0.94 related to visionos.

[briansmith]

Thanks. I think we need to go through the release notes of cc-rs 1.0.94 and higher, and recent issues in that crate, to verify that requiring such a new release is not going to be problematic, given recent instability regarding Apple targets in that crate.

[eugenehp]

so what would be the best course of action here? seems like rust-lang/cc-rs#984 is still a blocker.

original PR was merged on April 12, and release followed on April 13
https://github.com/rust-lang/cc-rs/releases/tag/1.0.93

ps: we did run tests on cc = { version = "1.0.98", default-features = false } and it worked fine for all devices with the host systems on Apple Silicon (M1, M2, M3). Haven't tested on older X86_64.

[briansmith]

Maybe we could leave the cc-rs dependency as-is but add a comment above it saying cc-rs 1.0.94 or later is required for visionos support, but we're waiting to increase our dependency until rust-lang/cc-rs#984 and maybe other issues are addressed, and also add a note to that same effect to BUILDING.md. Then we can merge this.

[eugenehp]

yeah, a conditional dependency in Cargo.toml sounds like a feasible option.

@QuentinPerez wanna do it?

[briansmith]

Closing in favor of #2112 and #2113. Please see those PRs for important details. I would appreciate testing of them and feedback, especially related to performance and code size.