Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-127020 Move autoFocus functionality to the management toolbar taglib #99157

Closed
wants to merge 2 commits into from

Conversation

wincent
Copy link

@wincent wincent commented Feb 24, 2021

Manual forward from: liferay-frontend#833

CI was green here, other than the known-issue upstream failure (LocalFile.WebContentWithCustomStructures#AddWebContentWithRepeatableRichTextField) that was fixed yesterday.

Original PR description follows.


Task ticket: https://issues.liferay.com/browse/LPS-127020
Related discussions:

Notes:

<clay:management-toolbar
	searchInputAutoFocus="<%= true %>"
	searchInputName="mySearchInputName"
/>

rhymes with

<ClayInput
	autoFocus={searchInputAutoFocus}
	name={searchInputName}
/>

/cc @wincent @4lejandrito @jbalsas @julien @jonmak08 @ambrinchaudhary

Test sample in clay-sample-web:

after

@liferay-continuous-integration
Copy link
Collaborator

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

@wincent
Copy link
Author

wincent commented Feb 24, 2021

ci:reopen

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 59ee92b...a35eb22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants