-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoFocus to management toolbar #3895
Comments
@4lejandrito I think this is a fix that needs to be made in the DXP implementation of ManagementToolbar. If you want, you can go ahead and send a PR to the |
Hi @bryceosterhaus, We're happy to implement it just for DXP but I still think it belongs to the clay component. Feel free to close this ticket and we will create an LPS to implement it in portal. Thanks! |
@4lejandrito that should already be possible with components in Clay@v3. Our management toolbar package contains a bunch of low-level components to be composed together. If you look at our storybook example of Management toolbar, you would just need to add that |
I didn't know that. Then it sounds much better. Thanks @bryceosterhaus! |
What is your proposal?
To add the
autoFocus
property to the management toolbar component so that the search box gains focus if present.Why would adopting this proposal be beneficial?
At the moment we have this piece of code in Documents and Media to achieve that. It is not only ugly but also caused some recent issues and will likely break again in the future.
What are the alternatives to this proposal?
Keep using our ugly code 😢 .
Thanks!
The text was updated successfully, but these errors were encountered: