-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include pg-connection-string into monorepo #2184
Conversation
Support usage of relative urls to set database on the default host
Add supporting password with colon
Update README.md
To make this app consumable by Typescript apps a typings file must be present.
Copy all but special-cased params from URL query string to config
Add support for Typescript typings thanks @NoNameProvided !
thanks, @caub !
* some tests * coveralls and mocha * coveralls post test hook * remove done calls
This fix adds the ability to use username and password even when using a socket.
The connection string now supports the following parameters: - sslcert - sslkey - sslrootcert Fixes #25.
Add support for TLS parameters in URI
Only publish the required files
Add supporting username and password for socket connections
ssl=0 is now parses to false
Closes #15
Update coveralls badge
fix readme newline typo
Support more modes to set the host as a socket
This summarizes the common forms, but omits some of the more particular, and unnecessary forms, such as specifying UNIX domain sockets with `pg://` URLs.
Include documentation on the URL format in the README
note: need to merge this with a merge commit to preserve history. |
I think the new syntax I'm using here is compatible with `sh`...let's see.
@hjr3 Thanks for your help in getting this moved over! Before I can take dependency on this version from within the monorepo I'd like to make sure I have enough access to the npm package on npmjs.com to be a maintainer of it long term. That means enough access to publish to the package & add/remove collaborators. You're absolutely welcome to be a co-owner...I just need to have enough access in case you ever decide you don't wanna bother anymore so we can have continuity of ownership! If there's anything you need from me to help w/ this that isn't able to be discussed in public please feel free to email me or just ping me here! |
Glad I could help. I pinged the repo (and I think npm?) owners in iceddev/pg-connection-string#37 (comment) . I believe @monteslu is the person who can help with the transition. |
Not super familiar with monorepos yet. We get to keep the commit history with moving this right? |
perfect! I've added you to the npm package. |
awesome thanks @monteslu - I'm gonna try publishing a new patch version now. You might wanna redirect the existing iceddev repo over here. Please feel free to collab & contribute here as much or as little as you want. I'll consider myself a "co-owner" in that I'll take responsibility for anything that merges in and shepherd the project if you get burnt out or want to go do something else, but I don't plan on standing in your way at all if you want to continue to drive it forward yourself over here too! ❤️ The main motivation here is to make it easier to integrate changes to |
💃 I'll work on getting a semver minor release of pg & friends out tomorrow to re-baseline on top of this version of |
After some discussions I'm going to bring pg-connection-string into this repo. This will help out w/ making it easier to control the SSL parameters from the connection string.