NULL for numeric fields -> NaN

[dvv]

Hi!

On the same setup as in https://gist.github.com/929626 :

create table foo(id bigint, num bigint);
insert into foo(id) values(1);

...
db.query('select * from foo').on('row', function(row){
console.log(row); // ---> {id: 1, num: NaN}
});

Can you confirm the issue?

TIA,
--Vladimir

[brianc]

I can confirm after work. If this is indeed the case I'll write test & fix the issue tonight.

[dvv]

I'm GMT+03, what are you (to sync the time window)? Is there a dedicated IRC channel for this project?

[brianc]

this passes for me:

test('selecting null integers', function() {
  pg.connect(connectionString, assert.calls(function(err, client) {
    client.query("CREATE TEMP TABLE foo(id bigint, num bigint)");
    client.query("INSERT INTO foo(id) values(1)");
    var q = client.query("SELECT * FROM foo");
    assert.emits(q, 'row', function(row) {
      assert.equal(row.id, 1);
      assert.ok(row.num === null);
    })
  }))
})

[dvv]

Do you use native? If yes, it's a miracle, since I see in the code the use of plain JS parseInt to convert from DB to JS integers

[dvv]

Rechecked. Right, for JS client it's null. For native libpq client it's NaN.

[brianc]

Yeah...that test was passing under native & pure javascript.

[dvv]

So you can't reproduce it?

[dvv]

libpq version-dependent may be...

[brianc]

@dvv are you able to run the test suite locally? If you could run that it would be really helpful. If you need help getting the suite set up (it requires a few records to exist in your test database) you can look here or ask on this thread. Maybe there's something particular to your setup the tests could help shake out?

[dvv]

make test-all passed ok.

[napa3um]

client.query('insert into "table" ("field") values ($1) returning "id";', [null], function(){});

TypeError: Cannot call method 'toString' of undefined

error for native version, ok for js version

[napa3um]

sorry, I tried null and undefined therefore the error doesn't correspond to parameter in an example :)

[brianc]

So...@napa3um your code example is indeed throwing an error or not?

[napa3um]

var pg = require('pg').native;
// var pg = require('pg');

var testArg = null;
// var testArg = 1;

pg.connect("tcp://httpd:374@localhost/node", function(err, client){
if(err) errExit(err);

client.query('select 7 <> $1 as res;', [testArg], function(err, res){
    if(err) errExit(err);

    console.log(res.rows[0].res);
    process.exit();
});

});

function errExit(err){
console.error(err.message);
process.exit(-1);
}

---

napa3um@hive:~/Workspace/node.js/amedia$ node pg-error.js

/home/napa3um/Workspace/node.js/amedia/node_modules/pg/lib/native.js:201
return val.toString();
^
TypeError: Cannot call method 'toString' of null
at /home/napa3um/Workspace/node.js/amedia/node_modules/pg/lib/native.js:201:18
at Array.map (native)
at [object Object]._translateValues (/home/napa3um/Workspace/node.js/amedia/node_modules/pg/lib/native.js:200:31)
at new (/home/napa3um/Workspace/node.js/amedia/node_modules/pg/lib/native.js:156:8)
at Connection.query (/home/napa3um/Workspace/node.js/amedia/node_modules/pg/lib/native.js:49:11)
at /home/napa3um/Workspace/node.js/amedia/pg-error.js:10:9
at Connection. (/home/napa3um/Workspace/node.js/amedia/node_modules/pg/lib/client-pool.js:87:11)
at Connection.g (events.js:143:14)

[napa3um]

one more problem which isn't present in the js-version:

// var pg = require('pg');
var pg = require('pg').native;

pg.connect("tcp://httpd:374@localhost/node", function(err, client){
if(err) errExit(err);

client.query('select null as res;', function(err, res){
    if(err) errExit(err);

    console.log(res.rows[0].res == null);
    process.exit();
});

});

---

napa3um@hive:~/Workspace/node.js/amedia$ node pg-error.js
false

[brianc]

Awesome. I've confirmed the issue w/ some unit tests & will work on a patch this evening. Thanks!

[brianc]

found a fix for this and a few other native related bugs dealing with null values as well....I need to test on various other operating system/postgres combos and then I'll release a new version in npm. thanks again.

[brianc]

Fixed. npm install pg for latest version