Start testing Rails 5 #203
Conversation
Callback declarations etc… don’t have to be done inside class_eval Add attr_reader :position_changed to initialise @position_changed Convert the removal of @scope_changed into a private method callable by a callback raise_in_transactional_callbacks is true and unchangeable in Rails 5 Remove use of unused parent variable Use data_sources instead of tables. This method returns views too, but our tests don’t use views, so this is safe to use in the dropping of tables.
|
Ok, I've cleared out the deprecations and other warnings. Now it's just the actual failing tests, and I'm almost certain it has to do with the attribute swapper functionality. Probably to do with the usage of the internal variable. I'll try to see if we can work around that. |
|
Hi @swanandp, tests are green. I've made the attribute swapping better in my opinion. We're no longer using an undocumented internal variable. I didn't check, but I think that variable name probably changed between versions. This change is better since we're now using only the external interface. I've also dropped the extra swap_attributes method since we're only doing this in one place, it make sense to just do it there. |
|
I've decided to merge this. Everything seems to be working. |
There are plenty of failing tests, deprecations, and warnings. At least this works as a starting point for getting these ironed out.