Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing string to define callback is deprecated in rails 5 #181

Closed
wants to merge 1 commit into from
Closed

Passing string to define callback is deprecated in rails 5 #181

wants to merge 1 commit into from

Conversation

oleander
Copy link

@oleander oleander commented Jan 8, 2016

Fixes this warning.

DEPRECATION WARNING: Passing string to define callback is deprecated and will be removed in Rails 5.1 without replacement. (called from acts_as_list at ~/.rvm/gems/ruby-2.2.4/bundler/gems/acts_as_list/lib/acts_as_list/active_record/acts/list.rb:126)

houndci-bot
houndci-bot reviewed Jan 8, 2016
View reviewed changes
lib/acts_as_list/active_record/acts/list.rb
@@ -471,4 +471,4 @@ def check_top_position
end
end
end
end
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final newline missing.

@oleander oleander mentioned this pull request Feb 17, 2016
Closed
@brendon
Copy link
Owner

brendon commented Apr 17, 2016

There seems to be some problem with a string still being passed. It's also not just this particular line. We'll investigate in the Rails 5 PR: #203

@brendon brendon closed this Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleander @brendon @houndci-bot