This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
fix webkit bug with release of context menu node #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always call SetShowingContextMenu/NotifyContextMenuClosed fix brave/browser-laptop#10563 also fixes flash context menu items not working
darkdh
reviewed
Sep 22, 2017
| const embedder = sender.hostWebContents || sender | ||
| win = BrowserWindow.fromWebContents(embedder) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
// menu.popup(x, y, positioningItem) should be put here
bridiver
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 22, 2017
bridiver
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 22, 2017
|
we should really be using ContextMenuDelegate/RenderViewContextMenuBase, but this works for now |
bridiver
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 22, 2017
bsclifton
added a commit
that referenced
this pull request
Sep 25, 2017
fix webkit bug with release of context menu node
bsclifton
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 26, 2017
bsclifton
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 26, 2017
bsclifton
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 26, 2017
kevinlawler
pushed a commit
to brave/browser-laptop
that referenced
this pull request
Oct 5, 2017
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this pull request
Nov 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always call SetShowingContextMenu/NotifyContextMenuClosed
fix brave/browser-laptop#10563
also fixes flash context menu items not working