Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

changes for https://github.com/brave/muon/pull/317 #11099

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Sep 22, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #11099 into master will decrease coverage by 0.02%.
The diff coverage is 19.6%.

@@            Coverage Diff             @@
##           master   #11099      +/-   ##
==========================================
- Coverage    53.4%   53.37%   -0.03%     
==========================================
  Files         251      251              
  Lines       21760    21781      +21     
  Branches     3405     3407       +2     
==========================================
+ Hits        11620    11626       +6     
- Misses      10140    10155      +15
Flag Coverage Δ
#unittest 53.37% <19.6%> (-0.03%) ⬇️
Impacted Files Coverage Δ
js/contextMenus.js 18.46% <ø> (+0.54%) ⬆️
js/constants/appConstants.js 100% <ø> (ø) ⬆️
js/actions/appActions.js 13.19% <0%> (-0.1%) ⬇️
app/common/state/tabState.js 77.81% <0%> (-0.42%) ⬇️
app/browser/tabs.js 28.9% <0%> (-0.11%) ⬇️
js/flash.js 22.72% <18.42%> (-2.54%) ⬇️
app/browser/reducers/tabsReducer.js 42.66% <60%> (-0.58%) ⬇️

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 23, 2017
@luixxiul
Copy link
Contributor

Do we need to do QA on this?

@darkdh
Copy link
Member

darkdh commented Sep 23, 2017

Yep, it will resolve #10563

@luixxiul luixxiul added the muon label Sep 23, 2017
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Sep 26, 2017
@bsclifton bsclifton removed the needs-info Another team member needs information from the PR/issue opener. label Sep 26, 2017
@bsclifton bsclifton merged commit 70f2f68 into master Sep 26, 2017
@bsclifton bsclifton deleted the issue-10563 branch September 26, 2017 15:56
@bsclifton
Copy link
Member

bsclifton commented Sep 26, 2017

master 70f2f68
0.20.x 9e6196c
0.19.x 5be8ccd

bsclifton added a commit that referenced this pull request Sep 26, 2017
bsclifton added a commit that referenced this pull request Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants