This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
changes for https://github.com/brave/muon/pull/317 #11099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11099 +/- ##
==========================================
- Coverage 53.4% 53.37% -0.03%
==========================================
Files 251 251
Lines 21760 21781 +21
Branches 3405 3407 +2
==========================================
+ Hits 11620 11626 +6
- Misses 10140 10155 +15
|
bridiver
force-pushed
the
issue-10563
branch
from
September 22, 2017 22:03
16f79b5
to
c79e31b
Compare
darkdh
approved these changes
Sep 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
bridiver
force-pushed
the
issue-10563
branch
from
September 22, 2017 22:31
c79e31b
to
f8ed44a
Compare
luixxiul
added
the
needs-info
Another team member needs information from the PR/issue opener.
label
Sep 23, 2017
Do we need to do QA on this? |
Yep, it will resolve #10563 |
bsclifton
removed
the
needs-info
Another team member needs information from the PR/issue opener.
label
Sep 26, 2017
bsclifton
added a commit
that referenced
this pull request
Sep 26, 2017
bsclifton
added a commit
that referenced
this pull request
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests