This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Adding NavigationEntry wrapper method for getting history page title. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this out locally after making this change https://github.com/bsclifton/browser-laptop/commit/db4352afd593250faccdcf63934046fea9855d4b This electron patch works great 😄 ready for review (and merge if approved)! |
3 tasks
|
Looks good! I'll merge after the Chrome 52 update |
…ron-prebuilt/dist
|
Just added (and tested) a new task for installing locally (thanks for the suggestion, @bbondy!) |
|
++ @bridiver pls just cherry-pick into chromium52 once that is sorted out, I have another api that I'm adding that Marshall needs so I'm going to push and merge this and spin v51 based builds for testing. |
bridiver
pushed a commit
that referenced
this pull request
Jul 27, 2016
Adding NavigationEntry wrapper method for getting history page title.
bridiver
pushed a commit
that referenced
this pull request
Aug 15, 2016
Adding NavigationEntry wrapper method for getting history page title.
bridiver
pushed a commit
that referenced
this pull request
Sep 17, 2016
Adding NavigationEntry wrapper method for getting history page title.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @bridiver
Getting familiar with electron 😄 Adding a method to help w/ getting information used in history.
Would be great if you can help me understand how to test locally (I tried a few things, no luck- I'm ready to update docs after I figure it out)