This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Show history on long click over back button #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(original feedback was given with #2435) |
…r forward button. Depends on brave/muon#30 Fixes #1622 (although it doesn't match the proposed mockup- a new issue can be filed for that) Ready for review! cc: @bbondy @bridiver - Adds dependency for jsdom-global (used for mocking window) - Includes extra tests for urlutilTest.js
|
So great to have this, I might have some follow up comments but let's do that in future commits if so. |
|
works like a charm! thanks :-) |
|
I noticed that the comment above was not reflected when I went back from another page until I reloaded this page. Is it as it should be? |
|
@luixxiul not sure what you mean- will shoot you a msg |
|
Also is it possible to use cache there? Favicons are reloaded in the pulldown list :-S |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.History now shows in context menu after a long press on back button or forward button.
Depends on brave/muon#30 (must be merged before this can be accepted)Fixes #1622
(although it doesn't match the proposed mockup- a new issue can be filed for that)
Ready for review!
cc: @bbondy @bridiver