This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Tab discarding/Tab strip #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
tab discarding works by creating a new empty webcontents and copying the navigation controller state from the current tab. It then detaches the old webcontents from the webview and attaches the new one. When the tab is activated it triggers a reload |
darkdh
reviewed
Mar 31, 2017
| @@ -208,6 +209,8 @@ void CommonWebContentsDelegate::SetOwnerWindow( | |||
| int32_t id = | |||
| api::Window::TrackableObject::GetIDFromWrappedClass(owner_window); | |||
| if (id > 0) { | |||
| SessionID sessionID; | |||
There was a problem hiding this comment.
Is sessionID not being used? TabHelper::SetWindowId will eventually set SessionID and use it so I think we can remove it here.
|
It is used right below your comment
… On Mar 31, 2017, at 2:10 PM, Anthony Tseng ***@***.***> wrote:
@darkdh commented on this pull request.
In atom/browser/common_web_contents_delegate.cc:
> @@ -208,6 +209,8 @@ void CommonWebContentsDelegate::SetOwnerWindow(
int32_t id =
api::Window::TrackableObject::GetIDFromWrappedClass(owner_window);
if (id > 0) {
+ SessionID sessionID;
Is sessionID not being used? TabHelper::SetWindowId will eventually set SessionID and use it so I think we can remove it here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
no I mean it should be used like SessionTabHelper::FromWebContents(web_contents())->SetWindowID(session); because |
|
If we let it auto set it will have the wrong value
… On Mar 31, 2017, at 3:49 PM, Anthony Tseng ***@***.***> wrote:
no I mean it should be used like SessionTabHelper::FromWebContents(web_contents())->SetWindowID(session); because set_id only store id in its private attribute
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bbondy
reviewed
Mar 31, 2017
| "//chrome/browser/engagement/site_engagement_score.cc", | ||
| "//chrome/browser/engagement/site_engagement_score.h", | ||
| "chrome/browser/engagement/site_engagement_service.cc", | ||
| "chrome/browser/lifetime/application_lifetime.cc", |
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tab discard support through chromium tab manager
also adds browser/tabstrip support for better src/chrome code compatibility
dep for brave/browser-laptop#2388