Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added tab discarding (put tabs to sleep if not in use) #2388

Closed
DivineOmega opened this issue Jul 4, 2016 · 6 comments
Closed

Added tab discarding (put tabs to sleep if not in use) #2388

DivineOmega opened this issue Jul 4, 2016 · 6 comments
Assignees
Milestone

Comments

@DivineOmega
Copy link

DivineOmega commented Jul 4, 2016

Test plan

#2388 (comment)


Google Chrome/Chromium currently supports a feature called tab discarding.

Does Brave currently support similar functionality, or if not are their plans to do so?
#1796

@DivineOmega
Copy link
Author

Thanks for your work on this! 😄

May I ask if this functions the same way as Chrome, and if there is a way to view a Brave equivalent of chrome://discards ?

@bbondy bbondy added this to the 0.14.2 milestone Apr 13, 2017
@bbondy
Copy link
Member

bbondy commented Apr 13, 2017

@DivineOmega pls post for chrome://discards if you don't mind in a new issue.

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Apr 17, 2017
@luixxiul
Copy link
Contributor

Is there any specific thing to test?

@bridiver
Copy link
Collaborator

@DivineOmega it uses the same memory-based tab discarding that Chrome does. We will be adding more features soon. @luixxiul there is a dev menu item that simulates a memory pressure event, but keep in mind that it will only discard non-active tabs and only if they are at least 10 min old.
Here is a test plan:

  1. Open brave.com
  2. Open a second tab with brave.com
  3. Wait at least 10 min
  4. Select "Simulate memory pressure event" from the dev menu
  5. Switch to the original tab
  6. Tab should reload because it was discarded

@luixxiul luixxiul added QA/test-plan-specified and removed needs-info Another team member needs information from the PR/issue opener. labels Apr 17, 2017
@alexwykoff
Copy link
Contributor

Cannot reproduce with RC builds.

I attempted to use memory_pressure in bash, but to no avail.

@bridiver
Copy link
Collaborator

bridiver commented Apr 18, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants