Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

don’t add the tab to tab state until the tab_helper has updated the v… #9507

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

bridiver
Copy link
Collaborator

…alues

fix #9506 along with brave/muon@4189da5
change is backwards compatible and muon commit is not required for merging

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
Difficult to add an automated test because the timing is critical. Steps outlined in related issue

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

…alues

fix #9506 along with brave/muon@4189da5
change is backwards compatible and muon commit is not required for merging
@bridiver bridiver added the bug label Jun 16, 2017
@bridiver bridiver self-assigned this Jun 16, 2017
@bridiver bridiver requested review from bbondy and darkdh June 16, 2017 02:06
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bridiver bridiver merged commit 8ead2c8 into master Jun 19, 2017
@bridiver bridiver added this to the 0.18.x (Developer Channel) milestone Jun 19, 2017
bsclifton pushed a commit that referenced this pull request Jun 19, 2017
don’t add the tab to tab state until the tab_helper has updated the v…
@cezaraugusto cezaraugusto deleted the issue-9506 branch June 21, 2017 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing the first tab of a window when restoring closes the entire window
2 participants