Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Closing the first tab of a window when restoring closes the entire window #9506

Closed
bridiver opened this issue Jun 16, 2017 · 2 comments · Fixed by #9507
Closed

Closing the first tab of a window when restoring closes the entire window #9506

bridiver opened this issue Jun 16, 2017 · 2 comments · Fixed by #9507
Assignees
@bridiver
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.17.13 (Release ...

Comments

@bridiver
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When restoring a window on startup, closing the first tab while the other tabs are still loading will close the entire window

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    bf34c40

  • Steps to reproduce:

    1. Open Brave with a fresh profile
    2. Open 10 tabs with twitter.com
    3. Close Brave
    4. Re-open Brave and press cmd/ctrl-w as soon as the first tab appears

  • Actual result:
    Window closes

  • Expected result:
    Only the tab should close

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@bridiver bridiver added the bug label Jun 16, 2017
@bridiver bridiver self-assigned this Jun 16, 2017
bridiver added a commit to brave/muon that referenced this issue Jun 16, 2017
@bridiver
set the window id when opening if it’s available
4189da5 
part of fix for brave/browser-laptop#9506 
auditors @bbondy @bsclifton
bridiver added a commit that referenced this issue Jun 16, 2017
@bridiver
don’t add the tab to tab state until the tab_helper has updated the v…
e261b9e 
…alues

fix #9506 along with brave/muon@4189da5
change is backwards compatible and muon commit is not required for merging
@bridiver bridiver mentioned this issue Jun 16, 2017
Merged
8 tasks
bridiver added a commit to brave/muon that referenced this issue Jun 16, 2017
@bridiver
set the window id when opening if it’s available
dc0a083 
part of fix for brave/browser-laptop#9506 
auditors @bbondy @bsclifton
@bridiver bridiver added this to the 0.18.x (Developer Channel) milestone Jun 19, 2017
bridiver added a commit that referenced this issue Jun 19, 2017
@bridiver
don’t add the tab to tab state until the tab_helper has updated the v…
ce8e853 
…alues

fix #9506 along with brave/muon@4189da5
change is backwards compatible and muon commit is not required for merging
This was referenced Jun 26, 2017
Closed
Closed
@bsclifton bsclifton modified the milestones: 0.17.x (Beta Channel), 0.18.x (Developer Channel) Jun 27, 2017
bsclifton pushed a commit that referenced this issue Jun 27, 2017
@bridiver @bsclifton
don’t add the tab to tab state until the tab_helper has updated the v…
0552012 
…alues

fix #9506 along with brave/muon@4189da5
change is backwards compatible and muon commit is not required for merging
@bsclifton bsclifton mentioned this issue Jun 27, 2017
Closed
@bsclifton bsclifton mentioned this issue Jun 27, 2017
Closed
@srirambv
Copy link
Collaborator

Verified on 0.17.11

This was referenced Jun 27, 2017
Closed
Closed
@LaurenWags
Copy link
Member

+1 from community https://community.brave.com/t/closing-top-open-tab-shuts-down-brave/4359

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging a pull request may close this issue.

don’t add the tab to tab state until the tab_helper has updated the v… brave/browser-laptop
5 participants
@bridiver @luixxiul @bsclifton @srirambv @LaurenWags